Bug 131326 - Fallback to default storage session when there isn't a valid session ID
Summary: Fallback to default storage session when there isn't a valid session ID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-07 16:17 PDT by Daniel Bates
Modified: 2014-04-08 09:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.23 KB, patch)
2014-04-07 16:49 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-04-07 16:17:37 PDT 
We should fallback to the default storage session in WebKit1 and WebKit2 without NetworkProcess when we have a null private browsing session so as to make our behavior consistent with the analogous behavior in WebKit2 with NetworkProcess.
Comment 1 Daniel Bates 2014-04-07 16:17:50 PDT 
<rdar://problem/16231679>
Comment 2 Daniel Bates 2014-04-07 16:49:17 PDT 
Created attachment 228771 [details]
Patch
Comment 3 Daniel Bates 2014-04-07 16:59:40 PDT 
I didn't include a test for this change because it's not obvious to me how to write a test that disables private browsing via WebKit preferences and starts a load before WebKit notifies WebCore of the preference change ([-WebView _preferencesChanged] is called in WebKit1) such that we update the session ID of the page. I am open to suggestions.
Comment 4 Daniel Bates 2014-04-08 09:10:02 PDT 
Committed r166928: <http://trac.webkit.org/changeset/166928>