Bug 131325 – [iOS WebKit2] WKPDFView fades in tiles, PDFs load very flashily

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

We should add and remove views as we scroll, and use a backing layer to avoid flashiness.

<rdar://problem/16382960>

[Tim Horton]

Created attachment 228769 [details]
patch

[Anders Carlsson]

Comment on attachment 228769 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228769&action=review

> Source/WebKit2/UIProcess/Cocoa/WKWebViewContentProvider.h:38
>  // FIXME: This should be API.

I think you should extend this FIXME to say that we should come up with a solution for the UIScrollViewDelegate “problem”.

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:134
> +        if (CGRectIntersectsRect(pageInfo.frame, targetRect)) {

Please change this to

if (!CGRectIntersectsRect(pageInfo.frame, targetRect)) {
    [pageInfo.view removeFromSuperview];
    pageInfo.view = nullptr;
    continue;
}

[Anders Carlsson]

Comment on attachment 228769 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228769&action=review

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:171
> +        pageInfo.view = nullptr;

No need to initialize view here since it's a RetainPtr.

[Tim Horton]

http://trac.webkit.org/changeset/166896