Bug 131324 - Web Inspector: test helper files should be under LayoutTests/http/tests/inspector/
Summary: Web Inspector: test helper files should be under LayoutTests/http/tests/inspe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks: 131318
  Show dependency tree / graph
 
Reported: 2014-04-07 16:06 PDT by Brian Burg
Modified: 2014-04-07 17:57 PDT (History)
5 users (show)

See Also:

Attachments
the patch (49.61 KB, patch)
2014-04-07 17:03 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-07 16:06:15 PDT 
If they are located in LayoutTests/inspector/, then any http tests cannot use the files. LayoutTests/http/tests/ is the file root for the test http server.
Comment 1 Brian Burg 2014-04-07 17:03:29 PDT 
Created attachment 228776 [details]
the patch
Comment 2 Joseph Pecoraro 2014-04-07 17:11:03 PDT 
Try adding the following to your ~/.gitconfig:

    [diff]
        renames = copies

I think it would make diffs like this significantly smaller and easier to read!
Comment 3 Joseph Pecoraro 2014-04-07 17:13:11 PDT 
Comment on attachment 228776 [details]
the patch

r=me
Comment 4 Brian Burg 2014-04-07 17:26:12 PDT 
(In reply to comment #2)
> Try adding the following to your ~/.gitconfig:
> 
>     [diff]
>         renames = copies
> 
> I think it would make diffs like this significantly smaller and easier to read!

Will do, thanks. I don't think I copied that to my centralized dot file repo.
Comment 5 WebKit Commit Bot 2014-04-07 17:57:03 PDT 
Comment on attachment 228776 [details]
the patch

Clearing flags on attachment: 228776

Committed r166901: <http://trac.webkit.org/changeset/166901>
Comment 6 WebKit Commit Bot 2014-04-07 17:57:06 PDT 
All reviewed patches have been landed.  Closing bug.