Bug 131285 - Make some bindings improvements, with smaller code size for error message generation
Summary: Make some bindings improvements, with smaller code size for error message gen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-06 16:43 PDT by Darin Adler
Modified: 2014-04-07 22:41 PDT (History)
11 users (show)

See Also:

Attachments
Patch (318.71 KB, patch)
2014-04-06 16:55 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (318.66 KB, patch)
2014-04-06 16:59 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (320.32 KB, patch)
2014-04-06 17:19 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (324.22 KB, patch)
2014-04-06 18:19 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (324.65 KB, patch)
2014-04-06 18:57 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-04-06 16:43:30 PDT 
Make some bindings improvements, with smaller code size for error message generation
Comment 1 Darin Adler 2014-04-06 16:55:37 PDT 
Created attachment 228707 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-06 16:58:12 PDT 
Attachment 228707 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314:  jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345:  jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355:  jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360:  jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365:  jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370:  jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375:  jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 12 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-04-06 16:59:38 PDT 
Created attachment 228708 [details]
Patch
Comment 4 WebKit Commit Bot 2014-04-06 17:01:04 PDT 
Attachment 228708 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314:  jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345:  jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355:  jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360:  jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365:  jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370:  jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375:  jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 12 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Adler 2014-04-06 17:19:41 PDT 
Created attachment 228709 [details]
Patch
Comment 6 WebKit Commit Bot 2014-04-06 17:22:04 PDT 
Attachment 228709 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314:  jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345:  jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355:  jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360:  jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365:  jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370:  jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375:  jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 12 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2014-04-06 18:07:13 PDT 
Comment on attachment 228709 [details]
Patch

r=me

This should be nice for binary bloat. Take care to fix mac and windows builds before landing.
Comment 8 Darin Adler 2014-04-06 18:19:31 PDT 
Created attachment 228711 [details]
Patch
Comment 9 WebKit Commit Bot 2014-04-06 18:21:52 PDT 
Attachment 228711 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314:  jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345:  jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355:  jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360:  jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365:  jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370:  jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375:  jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 12 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Darin Adler 2014-04-06 18:57:57 PDT 
Created attachment 228712 [details]
Patch
Comment 11 WebKit Commit Bot 2014-04-06 18:58:56 PDT 
Attachment 228712 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314:  jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345:  jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355:  jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360:  jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365:  jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370:  jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375:  jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 12 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Darin Adler 2014-04-06 20:44:04 PDT 
Committed r166864: <http://trac.webkit.org/changeset/166864>
Comment 13 Darin Adler 2014-04-07 22:41:08 PDT 
A fix for the isCalculated() assertion is in bug 131346.

I can’t reproduce the m_table assertion locally, even though it seems to be firing on all the bots. I also have no theory about it yet.
Comment 14 Darin Adler 2014-04-07 22:41:29 PDT 
(In reply to comment #13)
> A fix for the isCalculated() assertion is in bug 131346.
> 
> I can’t reproduce the m_table assertion locally, even though it seems to be firing on all the bots. I also have no theory about it yet.

Oops, that comment is for a different bug.