RESOLVED FIXED Bug 131268
Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits 
https://bugs.webkit.org/show_bug.cgi?id=131268
Summary Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits
Brian Burg
Reported 2014-04-05 11:21:12 PDT
This was used somehow to write tests for the network panel showing plugin network requests. I don't think we need this, unless there's some plan to start exposing plugin-related metrics.
Attachments
the patch (12.05 KB, patch)
2014-04-05 13:58 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
the patch, with old protocols fixed (45.26 KB, patch)
2014-04-05 14:18 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
the patch (12.05 KB, patch)
2014-04-05 17:53 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-05 11:28:35 PDT
<rdar://problem/16533381>
Timothy Hatcher
Comment 2 2014-04-05 13:51:43 PDT
Weird. This might be used for device emulation too, since iOS (and likely Android) have limits on the max size of resources. That said, we don't need it. the iOS simulator or a device is the best way to test that.
Brian Burg
Comment 3 2014-04-05 13:58:44 PDT
Created attachment 228683 [details] the patch
Brian Burg
Comment 4 2014-04-05 14:18:29 PDT
Created attachment 228684 [details] the patch, with old protocols fixed
Brian Burg
Comment 5 2014-04-05 14:22:15 PDT
Comment on attachment 228684 [details] the patch, with old protocols fixed wrong bug, webkit-patch got confused
Brian Burg
Comment 6 2014-04-05 17:53:27 PDT
Created attachment 228691 [details] the patch
WebKit Commit Bot
Comment 7 2014-04-05 22:56:25 PDT
Comment on attachment 228691 [details] the patch Clearing flags on attachment: 228691 Committed r166849: <http://trac.webkit.org/changeset/166849>
WebKit Commit Bot
Comment 8 2014-04-05 22:56:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.