Bug 131268 - Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits
Summary: Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-05 11:21 PDT by Brian Burg
Modified: 2014-04-05 22:56 PDT (History)
11 users (show)

See Also:

Attachments
the patch (12.05 KB, patch)
2014-04-05 13:58 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
the patch, with old protocols fixed (45.26 KB, patch)
2014-04-05 14:18 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
the patch (12.05 KB, patch)
2014-04-05 17:53 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-05 11:21:12 PDT 
This was used somehow to write tests for the network panel showing plugin network requests. I don't think we need this, unless there's some plan to start exposing plugin-related metrics.
Comment 1 Radar WebKit Bug Importer 2014-04-05 11:28:35 PDT 
<rdar://problem/16533381>
Comment 2 Timothy Hatcher 2014-04-05 13:51:43 PDT 
Weird. This might be used for device emulation too, since iOS (and likely Android) have limits on the max size of resources.

That said, we don't need it. the iOS simulator or a device is the best way to test that.
Comment 3 Brian Burg 2014-04-05 13:58:44 PDT 
Created attachment 228683 [details]
the patch
Comment 4 Brian Burg 2014-04-05 14:18:29 PDT 
Created attachment 228684 [details]
the patch, with old protocols fixed
Comment 5 Brian Burg 2014-04-05 14:22:15 PDT 
Comment on attachment 228684 [details]
the patch, with old protocols fixed

wrong bug, webkit-patch got confused
Comment 6 Brian Burg 2014-04-05 17:53:27 PDT 
Created attachment 228691 [details]
the patch
Comment 7 WebKit Commit Bot 2014-04-05 22:56:25 PDT 
Comment on attachment 228691 [details]
the patch

Clearing flags on attachment: 228691

Committed r166849: <http://trac.webkit.org/changeset/166849>
Comment 8 WebKit Commit Bot 2014-04-05 22:56:29 PDT 
All reviewed patches have been landed.  Closing bug.