Bug 131263 - REGRESSION (r163914): Application cache cannot be used in main frame
Summary: REGRESSION (r163914): Application cache cannot be used in main frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on: 128557
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-04 23:27 PDT by Alexey Proskuryakov
Modified: 2014-04-18 12:33 PDT (History)
5 users (show)

See Also:

Attachments
proposed fix (2.86 KB, patch)
2014-04-04 23:32 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
with release build fix (3.08 KB, patch)
2014-04-04 23:37 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-04 23:27:20 PDT 
We can't look at main frame URL when loading in main frame, because it comes from an unrelated previous page. And when loading into a new page, it's just empty.

<rdar://problem/16532063>
Comment 1 Alexey Proskuryakov 2014-04-04 23:27:50 PDT 
Regression tests didn't detect this, because they all test appcache in subframes.
Comment 2 Alexey Proskuryakov 2014-04-04 23:32:29 PDT 
Created attachment 228660 [details]
proposed fix
Comment 3 Alexey Proskuryakov 2014-04-04 23:37:00 PDT 
Created attachment 228661 [details]
with release build fix
Comment 4 Sam Weinig 2014-04-05 16:21:29 PDT 
Comment on attachment 228661 [details]
with release build fix

Can we add a regression test so this is caught in the future?
Comment 5 Alexey Proskuryakov 2014-04-05 17:19:32 PDT 
Comment on attachment 228661 [details]
with release build fix

I couldn't make a test quickly enough, it would have to be somewhat tricky.
Comment 6 WebKit Commit Bot 2014-04-05 17:48:30 PDT 
Comment on attachment 228661 [details]
with release build fix

Clearing flags on attachment: 228661

Committed r166844: <http://trac.webkit.org/changeset/166844>
Comment 7 WebKit Commit Bot 2014-04-05 17:48:33 PDT 
All reviewed patches have been landed.  Closing bug.