Bug 131251 - Remove bogus ASSERT in -JSVirtualMachine scanObjectGraph
Summary: Remove bogus ASSERT in -JSVirtualMachine scanObjectGraph
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-04 18:34 PDT by Mark Hahnenberg
Modified: 2014-04-05 12:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2014-04-04 20:27 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-04-04 18:34:17 PDT 
...
Comment 1 Mark Hahnenberg 2014-04-04 20:27:19 PDT 
Created attachment 228650 [details]
Patch
Comment 2 Filip Pizlo 2014-04-04 20:54:56 PDT 
Comment on attachment 228650 [details]
Patch

Why was it bogus?
Comment 3 Mark Hahnenberg 2014-04-04 21:20:26 PDT 
(In reply to comment #2)
> (From update of attachment 228650 [details])
> Why was it bogus?

If you look at the other code in JSVirtualMachine, it's all written in such a way where having duplicate entries between an owner and an owned object is ok (e.g. addManagedReference:withOwner:). I think I added this ASSERT before I made it okay to do that and just forgot to remove the ASSERT.
Comment 4 Geoffrey Garen 2014-04-05 10:41:35 PDT 
Comment on attachment 228650 [details]
Patch

r=me
Comment 5 Mark Hahnenberg 2014-04-05 12:26:32 PDT 
<rdar://problem/16520725>
Comment 6 WebKit Commit Bot 2014-04-05 12:54:45 PDT 
Comment on attachment 228650 [details]
Patch

Clearing flags on attachment: 228650

Committed r166835: <http://trac.webkit.org/changeset/166835>
Comment 7 WebKit Commit Bot 2014-04-05 12:54:47 PDT 
All reviewed patches have been landed.  Closing bug.