Bug 131228 - [GTK][CMAKE] build-webkit's parameter --no-webkit1 is not honored
Summary: [GTK][CMAKE] build-webkit's parameter --no-webkit1 is not honored
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Víctor M. Jáquez L.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-04 08:33 PDT by Víctor M. Jáquez L.
Modified: 2014-04-09 05:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2014-04-04 10:34 PDT, Víctor M. Jáquez L. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor M. Jáquez L. 2014-04-04 08:33:55 PDT 
When building webkit with

$ build-webkit --gtk --no-webkit1

GtkLaunch and the webkit1 libraries are built.
Comment 1 Víctor M. Jáquez L. 2014-04-04 10:34:23 PDT 
Created attachment 228602 [details]
Patch
Comment 2 Martin Robinson 2014-04-04 10:55:36 PDT 
Comment on attachment 228602 [details]
Patch

WebKit1 supports GTK3, so I'm not sure I understand the patch. We are going to remove WebKit1 soon, so perhaps we can just close this bug and wait for it to go away?
Comment 3 Víctor M. Jáquez L. 2014-04-04 11:14:31 PDT 
(In reply to comment #2)
> (From update of attachment 228602 [details])
> WebKit1 supports GTK3, so I'm not sure I understand the patch. We are going to remove WebKit1 soon, so perhaps we can just close this bug and wait for it to go away?

This patch removes the unconditional compilation of WebKit1 when compiling for GTK3.

Sure, we can close this bug and wait, or commit it and then removes its logic. Just I wanted to spot the issue.
Comment 4 Martin Robinson 2014-04-08 17:47:37 PDT 
WebKit1GTK+ has been removed.