WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
131210
Fast-path for casting JS wrappers to JSElement.
https://bugs.webkit.org/show_bug.cgi?id=131210
Summary
Fast-path for casting JS wrappers to JSElement.
Andreas Kling
Reported
2014-04-03 21:12:07 PDT
We should have a fast-path for casting JS wrappers to JSElement, too!
Attachments
Patch
(13.96 KB, patch)
2014-04-03 21:12 PDT
,
Andreas Kling
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-04-03 21:12:33 PDT
Created
attachment 228577
[details]
Patch
Benjamin Poulain
Comment 2
2014-04-03 21:16:20 PDT
Comment on
attachment 228577
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=228577&action=review
> Source/WebCore/bindings/js/JSElementCustom.h:38 > + return value.asCell()->type() >= JSElementType ? JSC::jsCast<JSElement*>(value) : nullptr;
>= is a dangerous game.
Andreas Kling
Comment 3
2014-04-03 21:43:23 PDT
Committed
r166765
: <
http://trac.webkit.org/changeset/166765
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug