RESOLVED FIXED 131192
Use more const refs in ShapeOutsideInfo and some misc cleanup 
https://bugs.webkit.org/show_bug.cgi?id=131192
Summary Use more const refs in ShapeOutsideInfo and some misc cleanup
Bem Jones-Bey
Reported 2014-04-03 16:58:50 PDT
Use more const refs in ShapeOutsideInfo and some misc cleanup
Attachments
Patch (9.14 KB, patch)
2014-04-03 17:00 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.06 KB, patch)
2014-04-04 10:33 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch for landing, this time with reviewer properly updated (9.06 KB, patch)
2014-04-04 10:35 PDT, Bem Jones-Bey 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2014-04-03 17:00:40 PDT
Created attachment 228561 [details] Patch
Zoltan Horvath
Comment 2 2014-04-03 17:17:11 PDT
The change looks good to me.
Dirk Schulze
Comment 3 2014-04-04 09:37:31 PDT
Comment on attachment 228561 [details] Patch r=me
WebKit Commit Bot
Comment 4 2014-04-04 09:40:00 PDT
Comment on attachment 228561 [details] Patch Rejecting attachment 228561 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 228561, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: le(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp Hunk #3 FAILED at 132. 1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dirk Schulze']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5822707933380608
Bem Jones-Bey
Comment 5 2014-04-04 10:33:58 PDT
Created attachment 228601 [details] Patch for landing
Bem Jones-Bey
Comment 6 2014-04-04 10:35:09 PDT
Created attachment 228603 [details] Patch for landing, this time with reviewer properly updated
WebKit Commit Bot
Comment 7 2014-04-04 10:36:33 PDT
Comment on attachment 228603 [details] Patch for landing, this time with reviewer properly updated Rejecting attachment 228603 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 228603, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp Hunk #4 FAILED at 159. 1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5221472641482752
Bem Jones-Bey
Comment 8 2014-04-04 11:36:56 PDT
Committed r166797: <http://trac.webkit.org/changeset/166797>
Note You need to log in before you can comment on or make changes to this bug.