Bug 131192 - Use more const refs in ShapeOutsideInfo and some misc cleanup
Summary: Use more const refs in ShapeOutsideInfo and some misc cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks: 98664
  Show dependency tree / graph
 
Reported: 2014-04-03 16:58 PDT by Bem Jones-Bey
Modified: 2014-04-04 11:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.14 KB, patch)
2014-04-03 17:00 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch for landing (9.06 KB, patch)
2014-04-04 10:33 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch for landing, this time with reviewer properly updated (9.06 KB, patch)
2014-04-04 10:35 PDT, Bem Jones-Bey 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2014-04-03 16:58:50 PDT 
Use more const refs in ShapeOutsideInfo and some misc cleanup
Comment 1 Bem Jones-Bey 2014-04-03 17:00:40 PDT 
Created attachment 228561 [details]
Patch
Comment 2 Zoltan Horvath 2014-04-03 17:17:11 PDT 
The change looks good to me.
Comment 3 Dirk Schulze 2014-04-04 09:37:31 PDT 
Comment on attachment 228561 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-04-04 09:40:00 PDT 
Comment on attachment 228561 [details]
Patch

Rejecting attachment 228561 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 228561, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
le(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
Hunk #3 FAILED at 132.
1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej
patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dirk Schulze']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5822707933380608
Comment 5 Bem Jones-Bey 2014-04-04 10:33:58 PDT 
Created attachment 228601 [details]
Patch for landing
Comment 6 Bem Jones-Bey 2014-04-04 10:35:09 PDT 
Created attachment 228603 [details]
Patch for landing, this time with reviewer properly updated
Comment 7 WebKit Commit Bot 2014-04-04 10:36:33 PDT 
Comment on attachment 228603 [details]
Patch for landing, this time with reviewer properly updated

Rejecting attachment 228603 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 228603, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t

Parsed 3 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
Hunk #4 FAILED at 159.
1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej
patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5221472641482752
Comment 8 Bem Jones-Bey 2014-04-04 11:36:56 PDT 
Committed r166797: <http://trac.webkit.org/changeset/166797>