By default JSContext Inspection includes the native call stack above the JSC API boundary when there is a JavaScript exception in the context. For example: @implementation Foo - (void)bar { JSContext *context = [[JSContext alloc] init]; [context evaluateScript:@"var a=;"]; // Throws an exception. } @end A JSContext inspector will see the JS exception stack "(anonymous function)" and the "-[JSContext evaluateScript], -[Foo bar], ..." call frames. Some clients, may not want that. Provide SPI to turn off this behavior, so that only the JS exception stack will be visible. <rdar://problem/16507210>
Created attachment 228552 [details] [PATCH] Proposed Fix
Attachment 228552 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSContextPrivate.h:45: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228552 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=228552&action=review r=me > Source/JavaScriptCore/API/JSContextPrivate.h:46 > +@property > +@discussion Set whether or not the native call stack is included when reporting exceptions. Default value is YES. > +*/ > +@property (setter=_setIncludeNativeCallStackWhenReportingExceptions:) BOOL _includeNativeCallStackWhenReportingExceptions NS_AVAILABLE(10_10, 8_0); > + I think the preferred terminology when it comes to verbs is the infinitive: "setIncludes" instead of "setInclude". c.f. – autosaves – setAutosaves: – setSuppressesIncrementalRendering: – suppressesIncrementalRendering
Created attachment 228563 [details] [PATCH] For Landing
Attachment 228563 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSContextPrivate.h:45: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228563 [details] [PATCH] For Landing Clearing flags on attachment: 228563 Committed r166756: <http://trac.webkit.org/changeset/166756>