Merge ShapeInfo & ShapeOutsideInfo now that ShapeInsideInfo is no more
Created attachment 228533 [details]
Comment on attachment 228533 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=228533&action=review
> +bool checkShapeImageOrigin(Document& document, CachedImage& cachedImage)
This function is only used by ShapeOutsideInfo::isEnabledFor. Can we just make it static?
> +bool checkShapeImageOrigin(Document&, CachedImage&);
...and we won't need this.
> +inline LayoutUnit borderBeforeInWritingMode(const RenderBox& renderer, WritingMode writingMode)
We have some inlines like this, would it make sense to make it inline statics?
Created attachment 228545 [details]
Updated for comments
Comment on attachment 228545 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=228545&action=review
> + InfoMap::AddResult result = infoMap.add(&key, std::make_unique<ShapeOutsideInfo>(key));
I'd use "auto" here.
Created attachment 228548 [details]
Patch for landing
Comment on attachment 228548 [details]
Clearing flags on attachment: 228548
Committed r166752: <http://trac.webkit.org/changeset/166752>
All reviewed patches have been landed. Closing bug.