Bug 131160 - [EFL][WK2] Add ewk API to allow accepting a specific TLS certificate for a specific host
Summary: [EFL][WK2] Add ewk API to allow accepting a specific TLS certificate for a sp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Molnar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-03 05:46 PDT by Peter Molnar
Modified: 2014-12-04 05:44 PST (History)
11 users (show)

See Also:

Attachments
patch (5.63 KB, patch)
2014-04-03 05:49 PDT, Peter Molnar 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
patch for landing (5.88 KB, patch)
2014-12-04 00:27 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Molnar 2014-04-03 05:46:43 PDT 
Add ewk API to allow accepting a specific TLS certificate for a specific host
Comment 1 Peter Molnar 2014-04-03 05:49:44 PDT 
Created attachment 228501 [details]
patch

The certificate is now passed though the EFL API as a PEM string, to avoid making it depend on libsoup (GTlsCertificate).

I don't know if there is a better way to do this, if you have any idea, please let me know.
Comment 2 Csaba Osztrogonác 2014-12-03 04:57:59 PST 
Gyuyoung, what do you think about it?
Comment 3 Gyuyoung Kim 2014-12-03 18:38:35 PST 
Comment on attachment 228501 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228501&action=review

I don't have a big opinion about certification now. Patch looks fine to me.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:442
> +EAPI void ewk_context_tls_certificate_for_host_allow(Ewk_Context *ewkContext, const char *pem, const char *host);

%s/ewkContext/context/g
Comment 4 Csaba Osztrogonác 2014-12-04 00:27:05 PST 
Created attachment 242555 [details]
patch for landing
Comment 5 WebKit Commit Bot 2014-12-04 01:23:01 PST 
Comment on attachment 242555 [details]
patch for landing

Clearing flags on attachment: 242555

Committed r176786: <http://trac.webkit.org/changeset/176786>
Comment 6 Hunseop Jeong 2014-12-04 05:44:16 PST 
*** Bug 139254 has been marked as a duplicate of this bug. ***