Bug 131142 - Harden FilterOperation type casting
Summary: Harden FilterOperation type casting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 133203
  Show dependency tree / graph
 
Reported: 2014-04-02 20:17 PDT by Simon Fraser (smfr)
Modified: 2014-05-22 21:36 PDT (History)
12 users (show)

See Also:

Attachments
Patch (56.07 KB, patch)
2014-04-02 20:22 PDT, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-04-02 20:17:37 PDT 
Harden FilterOperation type casting
Comment 1 Simon Fraser (smfr) 2014-04-02 20:22:48 PDT 
Created attachment 228455 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-02 20:23:46 PDT 
Attachment 228455 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:66:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-04-03 13:58:34 PDT 
https://trac.webkit.org/changeset/166741
Comment 4 David Kilzer (:ddkilzer) 2014-04-03 16:04:11 PDT 
<rdar://problem/15426741>