Bug 131141 – [iOS][WK2] Add SPI to handle animated resize

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[iOS][WK2] Add SPI to handle animated resize

[Benjamin Poulain]

Created attachment 228453 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 228453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228453&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:181
> +    [self _frameOrBoundsChangedFrom:self.bounds];

This is a bit weird. Maybe from:CGZeroRect?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:447
> +    // FIXME: animated resize is gonna be a lot of fun. Some properties need to be updated live, others need to be stored
> +    // for the end of the animation.

I don't think this comment is useful.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:683
> +        CGFloat oldWebViewWidhtInContentCoordinate = oldBounds.size.width / contentZoomScale(self);

"Widht". Coordinates.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:686
> +        CGFloat visibleWebPageWidthInContentCoordinate = std::min([_contentView bounds].size.width, oldWebViewWidhtInContentCoordinate);
> +        CGFloat targetScale = bounds.size.width / visibleWebPageWidthInContentCoordinate;
> +        [_scrollView setZoomScale:targetScale];

I'm not really sure what you're trying to do here.

[Tim Horton]

Comment on attachment 228453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228453&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:683
> +        CGFloat oldWebViewWidhtInContentCoordinate = oldBounds.size.width / contentZoomScale(self);

typo "Widht"

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:684
> +        CGFloat visibleWebPageWidthInContentCoordinate = std::min([_contentView bounds].size.width, oldWebViewWidhtInContentCoordinate);

"WebPage"?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1160
> +    // FIXME: send a single message to the WebProcess to layout and repaint instead.

capitals at the beginning of a sentence

[Benjamin Poulain]

Committed r166750: <http://trac.webkit.org/changeset/166750>