Bug 131139 - Fix over-retain in SharedBufferCF's createCFData().
Summary: Fix over-retain in SharedBufferCF's createCFData().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-02 16:46 PDT by Andreas Kling
Modified: 2014-04-03 15:57 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2014-04-02 16:46 PDT, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-04-02 16:46:03 PDT 
Fix over-retain in SharedBufferCF's createCFData().
Comment 1 Andreas Kling 2014-04-02 16:46:27 PDT 
Created attachment 228445 [details]
Patch
Comment 2 Anders Carlsson 2014-04-02 16:47:53 PDT 
Comment on attachment 228445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228445&action=review

> Source/WebCore/platform/cf/SharedBufferCF.cpp:58
>          return m_cfData.get();

Can you just return m_cfData here?
Comment 3 Andreas Kling 2014-04-03 15:57:15 PDT 
Committed r166751: <http://trac.webkit.org/changeset/166751>