Bug 131136 - Remove FrameLoadRequest's m_lockHistory member since it's always false
Summary: Remove FrameLoadRequest's m_lockHistory member since it's always false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-02 16:13 PDT by Mark Rowe (bdash)
Modified: 2014-04-02 17:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.38 KB, patch)
2014-04-02 16:15 PDT, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-04-02 16:13:29 PDT 
FrameLoadRequest initialize m_lockHistory to false. Nothing ever calls setLockHistory to alter the value. The one call site that checks for the value being true can be removed.
Comment 1 Mark Rowe (bdash) 2014-04-02 16:15:42 PDT 
Created attachment 228438 [details]
Patch
Comment 2 Andreas Kling 2014-04-02 17:15:27 PDT 
Comment on attachment 228438 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-04-02 17:56:36 PDT 
Comment on attachment 228438 [details]
Patch

Clearing flags on attachment: 228438

Committed r166685: <http://trac.webkit.org/changeset/166685>
Comment 4 WebKit Commit Bot 2014-04-02 17:56:38 PDT 
All reviewed patches have been landed.  Closing bug.