Bug 131135 - Introduce LockHistory and LockBackForwardList enums to use in place of bools
Summary: Introduce LockHistory and LockBackForwardList enums to use in place of bools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-02 15:58 PDT by Mark Rowe (bdash)
Modified: 2014-04-02 17:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (50.47 KB, patch)
2014-04-02 16:11 PDT, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
Patch (51.32 KB, patch)
2014-04-02 16:27 PDT, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-04-02 15:58:38 PDT 
The lockHistory and lockBackForwardList arguments are often passed using literals at the call site. Using multiple consecutive boolean arguments makes it hard to keep track of which is which.
Comment 1 Mark Rowe (bdash) 2014-04-02 16:11:09 PDT 
Created attachment 228437 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-02 16:13:01 PDT 
Attachment 228437 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/FormSubmission.h:92:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/loader/FrameLoader.h:110:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2014-04-02 16:27:53 PDT 
Created attachment 228444 [details]
Patch
Comment 4 WebKit Commit Bot 2014-04-02 16:29:31 PDT 
Attachment 228444 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/FormSubmission.h:92:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/loader/FrameLoader.h:110:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2014-04-02 17:17:15 PDT 
Comment on attachment 228444 [details]
Patch

OK, r=me
Comment 6 WebKit Commit Bot 2014-04-02 17:51:34 PDT 
Comment on attachment 228444 [details]
Patch

Clearing flags on attachment: 228444

Committed r166684: <http://trac.webkit.org/changeset/166684>
Comment 7 WebKit Commit Bot 2014-04-02 17:51:37 PDT 
All reviewed patches have been landed.  Closing bug.