Bug 131132 – [webkitpy] perf profiler does not understand --call-graph argument

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Manuel Rego Casasnovas]

New version of perf profiler (3.13.6 in Debian testing) do not understand --call-graph argument.

So when running perf-tests enabling the profiler you get the following error:
callchain: Unknown --call-graph option value: --output

 usage: perf record [<options>] [<command>]
    or: perf record [<options>] -- <command> [<options>]

        --call-graph <mode[,dump_size]>
                          setup and enables call-graph (stack chain/backtrace) recording: fp dwarf

Using -g seems enough (from the manual):
       -g
           Enables call-graph (stack chain/backtrace) recording.

[Manuel Rego Casasnovas]

Created attachment 228433 [details]
Patch

[Zan Dobersek]

Looks OK.

Ryosuke, can you please give this a look?

[Ryosuke Niwa]

Comment on attachment 228433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228433&action=review

> Tools/ChangeLog:8
> +        New versions of perf profiler have changed the argument from --call-graph to -g.

Should we check the version?  Or is -g backward compatible?

[Manuel Rego Casasnovas]

(In reply to comment #3)
> (From update of attachment 228433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228433&action=review
> 
> > Tools/ChangeLog:8
> > +        New versions of perf profiler have changed the argument from --call-graph to -g.
> 
> Should we check the version?  Or is -g backward compatible?

-g has been there since a while ago, for example in previous versions you have:
       -g, --call-graph
           Do call-graph (stack chain/backtrace) recording.

So I hope it doesn't cause any issue.

[WebKit Commit Bot]

Comment on attachment 228433 [details]
Patch

Clearing flags on attachment: 228433

Committed r166711: <http://trac.webkit.org/changeset/166711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.