Bug 131125 - [iOS] Expose geolocation provider on the process pool
Summary: [iOS] Expose geolocation provider on the process pool
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Depends on:
Reported: 2014-04-02 13:55 PDT by Dean Jackson
Modified: 2014-04-02 16:43 PDT (History)
0 users

See Also:

Patch (4.23 KB, patch)
2014-04-02 13:58 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2014-04-02 16:24 PDT, Dean Jackson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-04-02 13:55:00 PDT
WKProcessPool does not expose a WKGeolocationProviderIOS, which means the WKContentView never triggers the policy request.

Comment 1 Dean Jackson 2014-04-02 13:58:31 PDT
Created attachment 228426 [details]
Comment 2 Dean Jackson 2014-04-02 14:00:20 PDT
Committed r166663: <http://trac.webkit.org/changeset/166663>
Comment 3 Dean Jackson 2014-04-02 16:24:28 PDT
Reopening to attach new patch.
Comment 4 Dean Jackson 2014-04-02 16:24:32 PDT
Created attachment 228442 [details]
Comment 5 mitz 2014-04-02 16:33:33 PDT
Comment on attachment 228442 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=228442&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolInternal.h:57
> +@interface WKProcessPool ()
>  @property(readonly) WKGeolocationProviderIOS *_geolocationProvider;

I think this can just go into the existing class extension up the file (guarded with TARGET_OS_IPHONE).
Comment 6 Dean Jackson 2014-04-02 16:43:26 PDT
Followup commit r166677