Bug 131120 - Added some more dataLog info for OSR exits
Summary: Added some more dataLog info for OSR exits
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Reported: 2014-04-02 13:09 PDT by Mark Lam
Modified: 2014-04-02 13:50 PDT (History)
6 users (show)

See Also:

the patch (3.72 KB, patch)
2014-04-02 13:13 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-04-02 13:09:26 PDT
Adding info about the OSR exit index, the bytecode index of the bytecode that is OSR exiting, and the reason for the OSR exit.  This change is for debugging code which only comes into play when we use the --printEachOSRExit option.
Comment 1 Mark Lam 2014-04-02 13:13:36 PDT
Created attachment 228418 [details]
the patch
Comment 2 Michael Saboff 2014-04-02 13:25:43 PDT
Comment on attachment 228418 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228418&action=review


> Source/JavaScriptCore/dfg/DFGOperations.cpp:1044
> +    dataLogF(" @ exit #%u (bc#%u, %s) with ", vm->osrExitIndex, debugInfo->bytecodeOffset, exitKindToString(debugInfo->kind));

Don't mix dataLogF and dataLog.  Use dataLog.
Comment 3 Mark Lam 2014-04-02 13:49:34 PDT
Comment on attachment 228418 [details]
the patch

Will land manually with Michael's suggested changes.
Comment 4 Mark Lam 2014-04-02 13:50:28 PDT
Thanks for the review.  Landed in r166662: <http://trac.webkit.org/r166662>.