Bug 131110 - [WinCairo] Compile error.
Summary: [WinCairo] Compile error.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-02 09:02 PDT by peavo
Modified: 2014-04-02 10:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2014-04-02 09:06 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-04-02 09:02:05 PDT
There's a compilation error in DragImageCairoWin.cpp, since Image::size() now returns a FloatSize instead of an IntSize.
Comment 1 peavo 2014-04-02 09:06:17 PDT
Created attachment 228400 [details]
Patch
Comment 2 Alex Christensen 2014-04-02 09:28:10 PDT
I was going to do something similar, but I don't have my windows machine to test it. This seems good to me if it works. I'm not following all this float/int stuff too closely, though.
Comment 3 peavo 2014-04-02 10:52:51 PDT
Thanks for looking into this, guys :)
Comment 4 WebKit Commit Bot 2014-04-02 10:55:17 PDT
Comment on attachment 228400 [details]
Patch

Clearing flags on attachment: 228400

Committed r166652: <http://trac.webkit.org/changeset/166652>
Comment 5 WebKit Commit Bot 2014-04-02 10:55:20 PDT
All reviewed patches have been landed.  Closing bug.