Split tile grid out from TileController

[Antti Koivisto]

Preparation for having multiple grids per TileController.

[Antti Koivisto]

Created attachment 228390 [details]
patch

[Anders Carlsson]

Comment on attachment 228390 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228390&action=review

> Source/WebCore/platform/graphics/ca/mac/TileController.h:2
> + * Copyright (C) 2011-2014 Apple Inc. All rights reserved.

We have to explicitly list all copyright years.

[Antti Koivisto]

> We have to explicitly list all copyright years.

Nope: https://bugs.webkit.org/show_bug.cgi?id=129065#c3

[Simon Fraser (smfr)]

Comment on attachment 228390 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228390&action=review

> Source/WebCore/platform/graphics/ca/mac/TileController.h:88
> +    // Public for TileGrid
> +    bool isInWindow() const { return m_isInWindow; }

I would prefer using friend class for this.

[Antti Koivisto]

https://trac.webkit.org/r166654

[Brent Fulgham]

This broke Mountain Lion and Mavericks tests.  E.g.,

-          (tile cache coverage 0, 0 800 x 1024)
+          (tile cache coverage -2147483648, -2147483648 -2147483648 x -2147483648)

[Antti Koivisto]

and https://trac.webkit.org/r166659

[Tim Horton]

Should this be closed?