RESOLVED FIXED 131102
Split tile grid out from TileController 
https://bugs.webkit.org/show_bug.cgi?id=131102
Summary Split tile grid out from TileController
Antti Koivisto
Reported 2014-04-02 05:32:59 PDT
Preparation for having multiple grids per TileController.
Attachments
patch (140.02 KB, patch)
2014-04-02 06:23 PDT, Antti Koivisto 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-04-02 06:23:10 PDT
Created attachment 228390 [details] patch
Anders Carlsson
Comment 2 2014-04-02 08:03:46 PDT
Comment on attachment 228390 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228390&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.h:2 > + * Copyright (C) 2011-2014 Apple Inc. All rights reserved. We have to explicitly list all copyright years.
Antti Koivisto
Comment 3 2014-04-02 08:44:22 PDT
> We have to explicitly list all copyright years. Nope: https://bugs.webkit.org/show_bug.cgi?id=129065#c3
Simon Fraser (smfr)
Comment 4 2014-04-02 10:06:16 PDT
Comment on attachment 228390 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228390&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.h:88 > + // Public for TileGrid > + bool isInWindow() const { return m_isInWindow; } I would prefer using friend class for this.
Antti Koivisto
Comment 5 2014-04-02 11:32:28 PDT
https://trac.webkit.org/r166654
Brent Fulgham
Comment 6 2014-04-02 12:28:39 PDT
This broke Mountain Lion and Mavericks tests. E.g., - (tile cache coverage 0, 0 800 x 1024) + (tile cache coverage -2147483648, -2147483648 -2147483648 x -2147483648)
Antti Koivisto
Comment 7 2014-04-02 12:53:46 PDT
and https://trac.webkit.org/r166659
Tim Horton
Comment 8 2014-04-02 17:36:23 PDT
Should this be closed?
Note You need to log in before you can comment on or make changes to this bug.