Bug 131099 – [GTK] Compile all installed resources as GResources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

We currently install a few images and wav file in $prefix/share. These resources are shared between wk1 and wk2. If we compile them as gresources, we don't have to worry anymore about resources not being available because wk was not yet installed, or using hacks to make out tools find the resources. This also avoid conflicts for parallel installable versions of webkit, since the resources dir installed is not versioned.

[Carlos Garcia Campos]

Created attachment 231460 [details]
Patch

[Philippe Normand]

Comment on attachment 231460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231460&action=review

> Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:-42
> -    return createBusFromAudioFile(absoluteFilename.get(), false, sampleRate);

Is this function used anywhere else now? I haven't checked :)

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 231460 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231460&action=review
> 
> > Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:-42
> > -    return createBusFromAudioFile(absoluteFilename.get(), false, sampleRate);
> 
> Is this function used anywhere else now? I haven't checked :)

It seems that mac also implements it (in both mac and IOS), but only EFL uses it.

platform/audio/AudioFileReader.h:PassRefPtr<AudioBus> createBusFromAudioFile(const char* filePath, bool mixToMono, float sampleRate);
platform/audio/efl/AudioBusEfl.cpp:    return createBusFromAudioFile(absoluteFilename.utf8().data(), false, sampleRate);
platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:PassRefPtr<AudioBus> createBusFromAudioFile(const char* filePath, bool mixToMono, float sampleRate)
platform/audio/ios/AudioFileReaderIOS.cpp:PassRefPtr<AudioBus> createBusFromAudioFile(const char* filePath, bool mixToMono, float sampleRate)
platform/audio/mac/AudioFileReaderMac.cpp:PassRefPtr<AudioBus> createBusFromAudioFile(const char* filePath, bool mixToMono, float sampleRate)

[Philippe Normand]

Comment on attachment 231460 [details]
Patch

Looks good, thanks!

[Carlos Garcia Campos]

Committed r168894: <http://trac.webkit.org/changeset/168894>