Remove one of the CSSProperty constructor, because it is obsolete.
Created attachment 228373 [details] Proposed patch
Comment on attachment 228373 [details] Proposed patch Attachment 228373 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5176408770871296 New failing tests: fast/inspector-support/style.html platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html fast/css/duplicate-property-in-rule-important.html fast/css/font-property-priority.html platform/mac/fast/scrolling/scroll-select-latched-mainframe.html fast/css/remove-shorthand.html fast/css/url-with-multi-byte-unicode-escape.html fast/css/important-js-override.html fast/backgrounds/repeat/parsing-background-repeat.html fast/css/cssText-shorthand.html fast/css/overflow-property.html fast/dom/background-shorthand-csstext.html platform/mac/fast/scrolling/scroll-div-latched-mainframe.html fast/css/webkit-mask-crash-implicit.html
Created attachment 228375 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 228373 [details] Proposed patch Attachment 228373 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5230628438016000 New failing tests: fast/inspector-support/style.html fast/css/duplicate-property-in-rule-important.html fast/css/font-property-priority.html fast/css/remove-shorthand.html fast/css/url-with-multi-byte-unicode-escape.html fast/css/important-js-override.html fast/backgrounds/repeat/parsing-background-repeat.html fast/css/cssText-shorthand.html fast/css/overflow-property.html fast/dom/background-shorthand-csstext.html fast/css/webkit-mask-crash-implicit.html
Created attachment 228379 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 228373 [details] Proposed patch Attachment 228373 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5223914061955072 New failing tests: fast/inspector-support/style.html fast/css/duplicate-property-in-rule-important.html fast/css/font-property-priority.html fast/css/remove-shorthand.html fast/css/url-with-multi-byte-unicode-escape.html fast/css/important-js-override.html fast/backgrounds/repeat/parsing-background-repeat.html fast/css/cssText-shorthand.html fast/css/overflow-property.html fast/dom/background-shorthand-csstext.html fast/css/webkit-mask-crash-implicit.html
Created attachment 228380 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 228373 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=228373&action=review > Source/WebCore/css/StyleProperties.h:78 > - CSSProperty toCSSProperty() const { return CSSProperty(propertyMetadata(), const_cast<CSSValue*>(propertyValue())); } > + CSSProperty toCSSProperty() const { return CSSProperty(id(), const_cast<CSSValue*>(propertyValue())); } Many test failures here. CSSProperty(id, value) is not the same as CSSProperty(metadata, value).
Created attachment 231687 [details] Proposed patch
Comment on attachment 231687 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231687&action=review > Source/WebCore/css/StyleProperties.h:70 > + bool isSetFromShorthand() const { return propertyMetadata().m_isSetFromShorthand; } > + int indexInShorthandsVector() const { return propertyMetadata().m_indexInShorthandsVector; } Please don’t add these new public member functions. We don’t need the functions at all, since they are only used in one place and that’s inside this class. And if you really felt compelled to add the functions, they should be private since they are only used by a member function.
Created attachment 231841 [details] Proposed patch You are right, the patch is updated.
Comment on attachment 231841 [details] Proposed patch Clearing flags on attachment: 231841 Committed r169314: <http://trac.webkit.org/changeset/169314>
All reviewed patches have been landed. Closing bug.