Bug 131089 - GMainLoopSource needs to link in WinCairo
Summary: GMainLoopSource needs to link in WinCairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-01 22:10 PDT by Alex Christensen
Modified: 2014-04-02 02:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2014-04-01 22:15 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-04-01 22:10:36 PDT 
The new GMainLoopSource functions need to be exported in WTF.dll to link with where they are used in the GStreamer code in WebCore.  Also, if video is disabled then I'm not using glib, so I'd like to add #if USE(GLIB) like the other wtf/gobject cpp files have.  One fix for with video, one fix for without video.
Comment 1 Alex Christensen 2014-04-01 22:15:46 PDT 
Created attachment 228362 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-02 02:15:00 PDT 
Comment on attachment 228362 [details]
Patch

Clearing flags on attachment: 228362

Committed r166636: <http://trac.webkit.org/changeset/166636>
Comment 3 WebKit Commit Bot 2014-04-02 02:15:04 PDT 
All reviewed patches have been landed.  Closing bug.