Bug 131088 - [iOS] Remove the legacy string drawing code
Summary: [iOS] Remove the legacy string drawing code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-01 20:57 PDT by Benjamin Poulain
Modified: 2014-04-02 19:38 PDT (History)
0 users

See Also:

Attachments
Patch (23.15 KB, patch)
2014-04-01 20:58 PDT, Benjamin Poulain 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-04-01 20:57:43 PDT 
[iOS] Remove the legacy string drawing code
Comment 1 Benjamin Poulain 2014-04-01 20:58:09 PDT 
Created attachment 228360 [details]
Patch
Comment 2 Sam Weinig 2014-04-01 23:07:11 PDT 
Comment on attachment 228360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228360&action=review

Yay!

> Source/WebKit/mac/Configurations/WebKit.xcconfig:30
> +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm MemoryMeasure.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationCoreLocationProvider.h WebGeolocationPrivate.h WebGeolocationProviderIOS.h WebMIMETypeRegistry.h ebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h WebSelectionRect.h WebUIKitDelegate.h WebUIKitSupport.h WebVisiblePosition.h;

I think you removed an extra W. ebNSStringExtrasIOS.h should be WebNSStringExtrasIOS.h.
Comment 3 Benjamin Poulain 2014-04-02 19:38:53 PDT 
Committed r166691: <http://trac.webkit.org/changeset/166691>