WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
131088
[iOS] Remove the legacy string drawing code
https://bugs.webkit.org/show_bug.cgi?id=131088
Summary
[iOS] Remove the legacy string drawing code
Benjamin Poulain
Reported
2014-04-01 20:57:43 PDT
[iOS] Remove the legacy string drawing code
Attachments
Patch
(23.15 KB, patch)
2014-04-01 20:58 PDT
,
Benjamin Poulain
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-04-01 20:58:09 PDT
Created
attachment 228360
[details]
Patch
Sam Weinig
Comment 2
2014-04-01 23:07:11 PDT
Comment on
attachment 228360
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=228360&action=review
Yay!
> Source/WebKit/mac/Configurations/WebKit.xcconfig:30 > +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm MemoryMeasure.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationCoreLocationProvider.h WebGeolocationPrivate.h WebGeolocationProviderIOS.h WebMIMETypeRegistry.h ebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h WebSelectionRect.h WebUIKitDelegate.h WebUIKitSupport.h WebVisiblePosition.h;
I think you removed an extra W. ebNSStringExtrasIOS.h should be WebNSStringExtrasIOS.h.
Benjamin Poulain
Comment 3
2014-04-02 19:38:53 PDT
Committed
r166691
: <
http://trac.webkit.org/changeset/166691
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug