Bug 131057 – Remove Settings::maximumDecodedImageSize()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Following up on bug #127029, comment #7, we should remove the setting Settings::maximumDecodedImageSize() and its related logic as this feature has various shortcomings. At the time of writing, the iOS port is the only port that makes use of this setting. That is, the iOS port is the only port that specifies a maximum decoded image size less than the port-independent default size (std::numeric_limits<size_t>::max()). Moreover, this feature is less useful to the iOS port as it has support infrastructure to subsample large images (*).

(*) We should look to make this support infrastructure platform-independent.

[Daniel Bates]

<rdar://problem/15626368>

[Daniel Bates]

Created attachment 228319 [details]
Patch

[Daniel Bates]

Maybe we should increase the maximum canvas area on iOS? Currently we limit the image buffer of the canvas to 20 MB.

[Darin Adler]

Comment on attachment 228319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:400
> +        // The image failed to be decoded. Either we need more image data or the image data is malformed.

"failed to be decoded" is not grammatical. I suggest "Image decoding failed."

> Source/WebCore/loader/cache/CachedImage.cpp:439
> +        // The image failed to be decoded; the image data is malformed.

Ditto.

[Daniel Bates]

(In reply to comment #4)
> (From update of attachment 228319 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review
> 
> > Source/WebCore/loader/cache/CachedImage.cpp:400
> > +        // The image failed to be decoded. Either we need more image data or the image data is malformed.
> 
> "failed to be decoded" is not grammatical. I suggest "Image decoding failed."

Will fix before landing.

> 
> > Source/WebCore/loader/cache/CachedImage.cpp:439
> > +        // The image failed to be decoded; the image data is malformed.
> 
> Ditto.

Will fix before landing.

[Daniel Bates]

Committed r166665: <http://trac.webkit.org/changeset/166665>