Bug 131042 - [iOS] add missing QuickTime plug-in replacement API
Summary: [iOS] add missing QuickTime plug-in replacement API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-01 09:26 PDT by Eric Carlson
Modified: 2014-04-03 08:47 PDT (History)
9 users (show)

See Also:

Attachments
Proposed patch. (48.86 KB, patch)
2014-04-01 09:46 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (48.97 KB, patch)
2014-04-01 16:07 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (49.05 KB, patch)
2014-04-02 12:03 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (49.07 KB, patch)
2014-04-02 12:57 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-04-01 09:26:00 PDT 
Finish replacement plug-in scripting API.
Comment 1 Eric Carlson 2014-04-01 09:46:54 PDT 
Created attachment 228295 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2014-04-01 09:49:55 PDT 
Attachment 228295 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/MediaPlayer.cpp:644:  Declaration has space between type name and * in NSArray *MediaPlayer  [whitespace/declaration] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2014-04-01 16:07:12 PDT 
Created attachment 228334 [details]
Updated patch
Comment 4 Eric Carlson 2014-04-02 12:03:56 PDT 
Created attachment 228408 [details]
Updated patch
Comment 5 Dean Jackson 2014-04-02 12:30:54 PDT 
Comment on attachment 228408 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228408&action=review

Weird. The patch includes QuickTimePluginReplacement.mm twice.

> Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Maybe +2014?
Comment 6 Eric Carlson 2014-04-02 12:57:15 PDT 
Created attachment 228414 [details]
Patch for landing
Comment 7 Eric Carlson 2014-04-03 08:47:07 PDT 
Committed r166719: https://trac.webkit.org/r166719