Bug 131039 - [EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html and Dromaeo performance tests crash
Summary: [EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 131010
  Show dependency tree / graph
 
Reported: 2014-04-01 08:41 PDT by Zsolt Borbely
Modified: 2014-04-01 17:50 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.09 KB, patch)
2014-04-01 09:29 PDT, Zsolt Borbely 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Borbely 2014-04-01 08:41:03 PDT 
Enabling CSS JIT on EFL made these performance tests crash:
Running CSS/QuerySelector.html (29 of 128)
error: CSS/QuerySelector.html
1   0x7f1a79a759f0
2   0x7f1a79dfeff0
3   0x7f1a79aaca25 WTF::equalIgnoringCaseNonNull(WTF::StringImpl const*, WTF::StringImpl const*)
4   0x7f1a200120b2
...
Comment 1 Zsolt Borbely 2014-04-01 09:29:19 PDT 
Created attachment 228293 [details]
Proposed patch
Comment 2 Csaba Osztrogonác 2014-04-01 09:31:07 PDT 
Comment on attachment 228293 [details]
Proposed patch

LGTM, r=me. GTK disabled CSS JIT too because of similar crashes.
Comment 3 Csaba Osztrogonác 2014-04-01 09:33:20 PDT 
Comment on attachment 228293 [details]
Proposed patch

Clearing flags on attachment: 228293

Committed r166593: <http://trac.webkit.org/changeset/166593>
Comment 4 Csaba Osztrogonác 2014-04-01 09:33:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Gyuyoung Kim 2014-04-01 17:50:38 PDT 
I agree to disable CSS JIT until fixing the crash. Thanks.