RESOLVED FIXED 131017
[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API 
https://bugs.webkit.org/show_bug.cgi?id=131017
Summary [EFL][WK2] Fix and update the existing test case for ewk_database_manager_ori...
Joonghun Park
Reported 2014-04-01 01:01:59 PDT
For the existing test case for ewk_database_manager_origins_async_get API 1. Fix the memory leak 2. revise variable naming style 3. fix error message caused by duplicated deletion of Ecore_Timer
Attachments
Patch (3.03 KB, patch)
2014-04-01 01:06 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (3.15 KB, patch)
2014-04-01 01:20 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (3.15 KB, patch)
2014-04-01 03:29 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2014-04-01 03:43 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2014-04-01 03:48 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2014-04-01 04:01 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2014-04-01 01:06:30 PDT
Created attachment 228253 [details] Patch
Ryuan Choi
Comment 2 2014-04-01 01:15:03 PDT
Comment on attachment 228253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228253&action=review > Source/WebKit2/ChangeLog:4 > + For the existing test case for ewk_database_manager_origins_async_get API > +fix the memory leak, revise variable naming style and fix error message caused by duplicated deletion of Ecore_Timer It's not bug title.
Joonghun Park
Comment 3 2014-04-01 01:20:50 PDT
Created attachment 228254 [details] Patch
Gyuyoung Kim
Comment 4 2014-04-01 01:54:58 PDT
Comment on attachment 228254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228254&action=review > Source/WebKit2/ChangeLog:9 > + For the existing test case for ewk_database_manager_origins_async_get API It is hard to understand what are you saying...:(
Joonghun Park
Comment 5 2014-04-01 03:29:20 PDT
Created attachment 228261 [details] Patch
Gyuyoung Kim
Comment 6 2014-04-01 03:35:33 PDT
Comment on attachment 228261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228261&action=review > Source/WebKit2/ChangeLog:11 > + and fix error message caused by duplicated deletion of Ecore_Timer > For the existing test case about ewk_database_manager_origins_async_get API, fix the memory leak, revise variable naming style and fix error message caused by duplicated deletion of Ecore_Timer How about below one ? Fix memory leaks and errors caused by duplication of Ecore_Timer deletion as well as update a naming style of local variable.
Joonghun Park
Comment 7 2014-04-01 03:43:47 PDT
Created attachment 228262 [details] Patch
Gyuyoung Kim
Comment 8 2014-04-01 03:45:49 PDT
Comment on attachment 228262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228262&action=review LGTM > Source/WebKit2/ChangeLog:3 > + [EFL][WK2]Fix and update the existing test case for ewk_database_manager_origins_async_get API Add a space between "[WK2]" and "Fix" before landing.
Joonghun Park
Comment 9 2014-04-01 03:48:52 PDT
Created attachment 228263 [details] Patch
Joonghun Park
Comment 10 2014-04-01 04:01:27 PDT
Created attachment 228264 [details] Patch
Gyuyoung Kim
Comment 11 2014-04-01 04:04:34 PDT
Comment on attachment 228264 [details] Patch Do not set r+ if you're not reviewer.
WebKit Commit Bot
Comment 12 2014-04-01 04:39:03 PDT
Comment on attachment 228264 [details] Patch Clearing flags on attachment: 228264 Committed r166576: <http://trac.webkit.org/changeset/166576>
WebKit Commit Bot
Comment 13 2014-04-01 04:39:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.