Bug 131014 - Prevent unnecessary copies in compareEqual template
Summary: Prevent unnecessary copies in compareEqual template
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-01 00:41 PDT by Zan Dobersek
Modified: 2014-04-01 08:36 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2014-04-01 00:46 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-04-01 00:41:46 PDT
Prevent unnecessary copies in compareEqual template
Comment 1 Zan Dobersek 2014-04-01 00:46:28 PDT
Created attachment 228250 [details]
Patch
Comment 2 Antti Koivisto 2014-04-01 03:08:08 PDT
Comment on attachment 228250 [details]
Patch

Good spotting. What did this affect?
Comment 3 Zan Dobersek 2014-04-01 08:34:55 PDT
There was no explicit performance issues as such, just an inefficiency that was spotted when looking for unnecessary HashMap copies.
Comment 4 Zan Dobersek 2014-04-01 08:36:11 PDT
Comment on attachment 228250 [details]
Patch

Clearing flags on attachment: 228250

Committed r166589: <http://trac.webkit.org/changeset/166589>
Comment 5 Zan Dobersek 2014-04-01 08:36:19 PDT
All reviewed patches have been landed.  Closing bug.