Bug 131008 - [Win] Correct media controls for test harness
Summary: [Win] Correct media controls for test harness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-31 20:54 PDT by Brent Fulgham
Modified: 2014-04-02 11:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2014-04-01 17:59 PDT, Brent Fulgham 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-03-31 20:54:19 PDT 
WebKit on Windows uses RenderThemeSafari theme while running tests to allow more Mac layout results to be used on Windows. When the media controls were switched to an HTML/CSS-based implementation, we forgot to update RenderThemeSafari.  This caused a great number of media tests to fail on Windows.

This patch corrects this problem so we can reactivate the offending tests.
Comment 1 Brent Fulgham 2014-04-01 17:59:23 PDT 
Created attachment 228351 [details]
Patch
Comment 2 Brent Fulgham 2014-04-01 18:01:09 PDT 
I'd like to land the test reactivation later, as I'm doing other test maintenance.
Comment 3 Brent Fulgham 2014-04-02 11:12:33 PDT 
Committed r166653: <http://trac.webkit.org/changeset/166653>