WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 131008
[Win] Correct media controls for test harness
https://bugs.webkit.org/show_bug.cgi?id=131008
Summary
[Win] Correct media controls for test harness
Brent Fulgham
Reported
2014-03-31 20:54:19 PDT
WebKit on Windows uses RenderThemeSafari theme while running tests to allow more Mac layout results to be used on Windows. When the media controls were switched to an HTML/CSS-based implementation, we forgot to update RenderThemeSafari. This caused a great number of media tests to fail on Windows. This patch corrects this problem so we can reactivate the offending tests.
Attachments
Patch
(5.44 KB, patch)
2014-04-01 17:59 PDT
,
Brent Fulgham
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-04-01 17:59:23 PDT
Created
attachment 228351
[details]
Patch
Brent Fulgham
Comment 2
2014-04-01 18:01:09 PDT
I'd like to land the test reactivation later, as I'm doing other test maintenance.
Brent Fulgham
Comment 3
2014-04-02 11:12:33 PDT
Committed
r166653
: <
http://trac.webkit.org/changeset/166653
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug