Bug 130992 - REGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
Summary: REGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-31 16:15 PDT by Michael Saboff
Modified: 2014-03-31 18:11 PDT (History)
0 users

See Also:


Attachments
Patch (3.00 KB, patch)
2014-03-31 16:32 PDT, Michael Saboff
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-03-31 16:15:57 PDT
The global object returned from JSContextGetGlobalObject() is actually wrapped by a JSProxy object.  The JSObjectGetPrivate() and JSObjectSetPrivate() don't work with the wrapped object.  The JSProxy was added in r166415 - <http://trac.webkit.org/changeset/166415>
Comment 1 Michael Saboff 2014-03-31 16:32:27 PDT
Created attachment 228219 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-31 16:34:45 PDT
Comment on attachment 228219 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-03-31 18:11:07 PDT
Committed r166554: <http://trac.webkit.org/changeset/166554>