Bug 130983 - Reduce Latched Scroll Test Flakiness
Summary: Reduce Latched Scroll Test Flakiness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-31 12:56 PDT by Brent Fulgham
Modified: 2014-03-31 14:23 PDT (History)
0 users

See Also:

Attachments
Patch (3.33 KB, patch)
2014-03-31 13:00 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2014-03-31 13:13 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Updated with rebaselined test output. (16.92 KB, patch)
2014-03-31 13:35 PDT, Brent Fulgham 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-03-31 12:56:57 PDT 
Try to reduce the flakiness of the new latched scrolling tests by building our NSEvents so that they satisfy the "hasPreciseScrollingDeltas" predicate.

The tests were designed to simulate precise scrolling on devices like the Apple Magic Mouse or trackpad, and may behave differently on systems that use a mechanical wheel mouse. Ensure this behavior on all test systems, regardless of installed hardware, by generating the mouse wheel events as though they came from high resolution mouse devices.
Comment 1 Brent Fulgham 2014-03-31 13:00:51 PDT 
Created attachment 228194 [details]
Patch
Comment 2 Brent Fulgham 2014-03-31 13:06:07 PDT 
Comment on attachment 228194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228194&action=review

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:476
> +    CGEventSetIntegerValueField(cgScrollEvent, kCGScrollWheelEventIsContinuous, 1);

Umm. cgScrollEvent.get() of course.
Comment 3 Brent Fulgham 2014-03-31 13:13:54 PDT 
Created attachment 228196 [details]
Patch
Comment 4 Brent Fulgham 2014-03-31 13:35:44 PDT 
Created attachment 228198 [details]
Updated with rebaselined test output.
Comment 5 Brent Fulgham 2014-03-31 14:23:21 PDT 
Committed r166530: <http://trac.webkit.org/changeset/166530>