RESOLVED FIXED130983
Reduce Latched Scroll Test Flakiness
https://bugs.webkit.org/show_bug.cgi?id=130983
Summary Reduce Latched Scroll Test Flakiness
Brent Fulgham
Reported 2014-03-31 12:56:57 PDT
Try to reduce the flakiness of the new latched scrolling tests by building our NSEvents so that they satisfy the "hasPreciseScrollingDeltas" predicate. The tests were designed to simulate precise scrolling on devices like the Apple Magic Mouse or trackpad, and may behave differently on systems that use a mechanical wheel mouse. Ensure this behavior on all test systems, regardless of installed hardware, by generating the mouse wheel events as though they came from high resolution mouse devices.
Attachments
Patch (3.33 KB, patch)
2014-03-31 13:00 PDT, Brent Fulgham
no flags
Patch (3.34 KB, patch)
2014-03-31 13:13 PDT, Brent Fulgham
no flags
Updated with rebaselined test output. (16.92 KB, patch)
2014-03-31 13:35 PDT, Brent Fulgham
darin: review+
Brent Fulgham
Comment 1 2014-03-31 13:00:51 PDT
Brent Fulgham
Comment 2 2014-03-31 13:06:07 PDT
Comment on attachment 228194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228194&action=review > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:476 > + CGEventSetIntegerValueField(cgScrollEvent, kCGScrollWheelEventIsContinuous, 1); Umm. cgScrollEvent.get() of course.
Brent Fulgham
Comment 3 2014-03-31 13:13:54 PDT
Brent Fulgham
Comment 4 2014-03-31 13:35:44 PDT
Created attachment 228198 [details] Updated with rebaselined test output.
Brent Fulgham
Comment 5 2014-03-31 14:23:21 PDT
Note You need to log in before you can comment on or make changes to this bug.