Bug 130965 – [CMake] Stop checking for WTF_USE_ICU_UNICODE.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raphael Kubo da Costa (:rakuco)]

[CMake] Stop checking for WTF_USE_ICU_UNICODE.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 228172 [details]
Patch

[Martin Robinson]

Comment on attachment 228172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review

> Source/JavaScriptCore/CMakeLists.txt:30
> +    "${ICU_INCLUDE_DIRS}"

I'm pretty sure you don't want parenthesis here, since there may be more than one directory.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #2)
> (From update of attachment 228172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review
> 
> > Source/JavaScriptCore/CMakeLists.txt:30
> > +    "${ICU_INCLUDE_DIRS}"
> 
> I'm pretty sure you don't want parenthesis here, since there may be more than one directory.

This should be fine; if the variable has a list each item is added as a separate path.

[Martin Robinson]

(In reply to comment #3)

> This should be fine; if the variable has a list each item is added as a separate path.

Won't it evaluate the list as "one two three" instead of "one" "two" "three" though?

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #4)
> (In reply to comment #3)
> 
> > This should be fine; if the variable has a list each item is added as a separate path.
> 
> Won't it evaluate the list as "one two three" instead of "one" "two" "three" though?

As in "-Ione two three" instead of "-Ione -Itwo -Ithree"? Not really; include_directories("one;two;three") becomes "-Ione -Itwo -Ithree".

[Raphael Kubo da Costa (:rakuco)]

Committed r166503: <http://trac.webkit.org/changeset/166503>

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #6)
> Committed r166503: <http://trac.webkit.org/changeset/166503>

This is a slightly modified version that does not quote ${ICU_INCLUDE_DIRS}.