Bug 130955 - [WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
Summary: [WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-30 21:33 PDT by Byungseon Shin
Modified: 2014-03-31 22:37 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.97 KB, patch)
2014-03-30 21:46 PDT, Byungseon Shin
no flags Details | Formatted Diff | Diff
Patch (9.96 KB, patch)
2014-03-31 18:09 PDT, Byungseon Shin
no flags Details | Formatted Diff | Diff
Patch (9.88 KB, patch)
2014-03-31 18:13 PDT, Byungseon Shin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Byungseon Shin 2014-03-30 21:33:45 PDT
[WebGL][OpenGLES]Enable MSAA support for WebGL Canvas
Comment 1 Byungseon Shin 2014-03-30 21:46:52 PDT
Created attachment 228146 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-30 21:48:05 PDT
Attachment 228146 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Extensions3D.h:116:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dean Jackson 2014-03-31 17:53:54 PDT
Comment on attachment 228146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228146&action=review

It would be great if we could write a test for this.

> Source/WebCore/ChangeLog:10
> +        - Imagination OpenGLES GPU Driver alreay support MSAA, so we

Typo: already

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:118
> +        GLint sampleCount = std::min(8, maxSampleCount);
> +        if (sampleCount > maxSampleCount)
> +            sampleCount = maxSampleCount;

You don't need the if clause. sampleCount is already less than or equal to maxSampleCount.
Comment 4 Byungseon Shin 2014-03-31 18:09:35 PDT
Created attachment 228225 [details]
Patch
Comment 5 WebKit Commit Bot 2014-03-31 18:11:07 PDT
Attachment 228225 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Extensions3D.h:116:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Byungseon Shin 2014-03-31 18:13:34 PDT
Created attachment 228226 [details]
Patch
Comment 7 Byungseon Shin 2014-03-31 18:14:22 PDT
@Dean, thanks for the review. 
About creating test case for it, I promise to do it as a separate commit.
Because it might need more work to do. :)
Comment 8 WebKit Commit Bot 2014-03-31 18:15:57 PDT
Attachment 228226 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Extensions3D.h:116:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2014-03-31 22:37:38 PDT
Comment on attachment 228226 [details]
Patch

Clearing flags on attachment: 228226

Committed r166563: <http://trac.webkit.org/changeset/166563>
Comment 10 WebKit Commit Bot 2014-03-31 22:37:42 PDT
All reviewed patches have been landed.  Closing bug.