Bug 130951 - Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
Summary: Move slow JSRegress tests out of the way so that they don't show up in run-js...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-30 20:10 PDT by Filip Pizlo
Modified: 2014-04-07 11:46 PDT (History)
8 users (show)

See Also:

Attachments
the patch (682.42 KB, patch)
2014-03-30 20:11 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-30 20:10:06 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-30 20:11:47 PDT 
Created attachment 228139 [details]
the patch
Comment 2 Csaba Osztrogonác 2014-03-31 04:07:28 PDT 
Comment on attachment 228139 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review

> Tools/ChangeLog:3
> +        Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running

I haven't find this run-jsc-benchmarks script in WebKit trunk and any test skipping 
in this patch. Referencing to an Apple internal script in the changelog is confusing.
Comment 3 Geoffrey Garen 2014-04-01 15:12:52 PDT 
Comment on attachment 228139 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review

>> Tools/ChangeLog:3
>> +        Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
> 
> I haven't find this run-jsc-benchmarks script in WebKit trunk and any test skipping 
> in this patch. Referencing to an Apple internal script in the changelog is confusing.

"//@ skip" skips a test.

I wonder, why isn't the run-jsc-benchmarks script open source?
Comment 4 Filip Pizlo 2014-04-01 15:36:36 PDT 
(In reply to comment #3)
> (From update of attachment 228139 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review
> 
> >> Tools/ChangeLog:3
> >> +        Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
> > 
> > I haven't find this run-jsc-benchmarks script in WebKit trunk and any test skipping 
> > in this patch. Referencing to an Apple internal script in the changelog is confusing.
> 
> "//@ skip" skips a test.
> 
> I wonder, why isn't the run-jsc-benchmarks script open source?

It's sort of open source.  See Tools/Scripts/bencher.  run-jsc-benchmarks is a customized version of this script that directly references tests that can't be landed in the WebKit repository despite being otherwise publicly available, like Kraken and JSBench.
Comment 5 Filip Pizlo 2014-04-07 11:46:15 PDT 
Landed in http://trac.webkit.org/changeset/166877