Bug 130945 - [Cocoa] Add an originatingWebView property to _WKDownload
Summary: [Cocoa] Add an originatingWebView property to _WKDownload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-30 13:13 PDT by Andy Estes
Modified: 2014-03-30 19:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (18.94 KB, patch)
2014-03-30 13:21 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (19.90 KB, patch)
2014-03-30 15:25 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-03-30 13:13:23 PDT 
[Cocoa] Add an originatingWebView property to _WKDownload
Comment 1 Andy Estes 2014-03-30 13:21:38 PDT 
Created attachment 228129 [details]
Patch
Comment 2 Anders Carlsson 2014-03-30 15:08:23 PDT 
Comment on attachment 228129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228129&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:248
> +    _webView.clear();

Please use = nullptr here instead.
Comment 3 Andy Estes 2014-03-30 15:25:36 PDT 
Created attachment 228133 [details]
Patch
Comment 4 Andy Estes 2014-03-30 15:27:42 PDT 
(In reply to comment #2)
> (From update of attachment 228129 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228129&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:248
> > +    _webView.clear();
> 
> Please use = nullptr here instead.

Thanks! Will do.

I uploaded a new patch before I saw your review, but the only difference is that I'm initializing allowOverwrite to NO in DownloadClient::decideDestinationWithSuggestedFilename().
Comment 5 Andy Estes 2014-03-30 15:34:24 PDT 
Committed r166466: <http://trac.webkit.org/changeset/166466>
Comment 6 Benjamin Poulain 2014-03-30 19:24:54 PDT 
Two APIs tests are failing after this. Can you please have a look?
Comment 7 Andy Estes 2014-03-30 19:38:36 PDT 
(In reply to comment #6)
> Two APIs tests are failing after this. Can you please have a look?

http://trac.webkit.org/changeset/166470 should fix them.