Bug 130936 - [GTK] Use PROJECT_VERSION_* instead of WEBKIT_*_VERSION
Summary: [GTK] Use PROJECT_VERSION_* instead of WEBKIT_*_VERSION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-29 15:17 PDT by Martin Robinson
Modified: 2014-03-31 07:39 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2014-03-29 23:35 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-29 15:17:39 PDT 
These are the common CMake project version variables and using them makes the build a bit less confusing.
Comment 1 Martin Robinson 2014-03-29 23:35:35 PDT 
Created attachment 228121 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-29 23:37:34 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2014-03-31 07:39:03 PDT 
Comment on attachment 228121 [details]
Patch

Clearing flags on attachment: 228121

Committed r166499: <http://trac.webkit.org/changeset/166499>
Comment 4 Martin Robinson 2014-03-31 07:39:08 PDT 
All reviewed patches have been landed.  Closing bug.