Bug 130922 - [CSS Blending] showLayerTree should dump layer's blend mode and isolation properties
Summary: [CSS Blending] showLayerTree should dump layer's blend mode and isolation pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 95614
  Show dependency tree / graph
 
Reported: 2014-03-28 17:20 PDT by Ion Rosca
Modified: 2014-03-31 14:07 PDT (History)
8 users (show)

See Also:

Attachments
adding blending debug values (18.96 KB, patch)
2014-03-28 17:30 PDT, Ion Rosca 		no flags Details | Formatted Diff | Diff
get blendMode from RenderLayer object (18.94 KB, patch)
2014-03-31 02:26 PDT, Ion Rosca 		no flags Details | Formatted Diff | Diff
#ifdef and isolation->isolatesBlending (19.02 KB, patch)
2014-03-31 10:34 PDT, Ion Rosca 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ion Rosca 2014-03-28 17:20:05 PDT 
showLayerTree does not provide information regarding blending.
It would be useful to add blendMode property and layer's isolation status (if it isolates some blending descendants).
Comment 1 Ion Rosca 2014-03-28 17:30:54 PDT 
Created attachment 228100 [details]
adding blending debug values
Comment 2 Ion Rosca 2014-03-31 02:26:14 PDT 
Created attachment 228159 [details]
get blendMode from RenderLayer object
Comment 3 Mihnea Ovidenie 2014-03-31 08:14:24 PDT 
Comment on attachment 228159 [details]
get blendMode from RenderLayer object

View in context: https://bugs.webkit.org/attachment.cgi?id=228159&action=review

You have to get Simon's or Dean's review on this but i will give you my opinion, hopefully it is valuable.

> Source/WebCore/rendering/RenderLayer.h:789
> +    BlendMode blendMode() const

I think we should wrap everything in CSS_COMPOSITING unless it is really important to have functions that work also when CSS_COMPOSITING is not enabled.

> Source/WebCore/rendering/RenderTreeAsText.cpp:631
> +    if (l.hasBlendMode())

I would use ENABLE(CSS_COMPOSITING) to guard this code. In addition to that, i would simply output "isolatesBlending" instead of "isolation" when a layer does this.
Comment 4 Ion Rosca 2014-03-31 10:34:39 PDT 
Created attachment 228183 [details]
#ifdef and isolation->isolatesBlending
Comment 5 WebKit Commit Bot 2014-03-31 14:07:14 PDT 
Comment on attachment 228183 [details]
#ifdef and isolation->isolatesBlending

Clearing flags on attachment: 228183

Committed r166525: <http://trac.webkit.org/changeset/166525>
Comment 6 WebKit Commit Bot 2014-03-31 14:07:19 PDT 
All reviewed patches have been landed.  Closing bug.