Bug 130922 – [CSS Blending] showLayerTree should dump layer's blend mode and isolation properties

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ion Rosca]

showLayerTree does not provide information regarding blending.
It would be useful to add blendMode property and layer's isolation status (if it isolates some blending descendants).

[Ion Rosca]

Created attachment 228100 [details]
adding blending debug values

[Ion Rosca]

Created attachment 228159 [details]
get blendMode from RenderLayer object

[Mihnea Ovidenie]

Comment on attachment 228159 [details]
get blendMode from RenderLayer object

View in context: https://bugs.webkit.org/attachment.cgi?id=228159&action=review

You have to get Simon's or Dean's review on this but i will give you my opinion, hopefully it is valuable.

> Source/WebCore/rendering/RenderLayer.h:789
> +    BlendMode blendMode() const

I think we should wrap everything in CSS_COMPOSITING unless it is really important to have functions that work also when CSS_COMPOSITING is not enabled.

> Source/WebCore/rendering/RenderTreeAsText.cpp:631
> +    if (l.hasBlendMode())

I would use ENABLE(CSS_COMPOSITING) to guard this code. In addition to that, i would simply output "isolatesBlending" instead of "isolation" when a layer does this.

[Ion Rosca]

Created attachment 228183 [details]
#ifdef and isolation->isolatesBlending

[WebKit Commit Bot]

Comment on attachment 228183 [details]
#ifdef and isolation->isolatesBlending

Clearing flags on attachment: 228183

Committed r166525: <http://trac.webkit.org/changeset/166525>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.