Bug 130921 - Web Inspector: console.warn is showing as error instead of warning
Summary: Web Inspector: console.warn is showing as error instead of warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-28 17:16 PDT by Joseph Pecoraro
Modified: 2014-03-28 17:31 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.30 KB, patch)
2014-03-28 17:19 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-28 17:16:23 PDT 
I regressed this when I moved console to JavaScriptCore. We are accidentally reporting console.warn as MessageLevel::Error instead of MessageLevel::Warning.

Take this opportunity to add a test, and update the fronted to use our enums instead of raw strings.
Comment 1 Radar WebKit Bug Importer 2014-03-28 17:18:43 PDT 
<rdar://problem/16463548>
Comment 2 Joseph Pecoraro 2014-03-28 17:19:05 PDT 
Created attachment 228098 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-03-28 17:31:05 PDT 
Comment on attachment 228098 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 228098

Committed r166439: <http://trac.webkit.org/changeset/166439>
Comment 4 WebKit Commit Bot 2014-03-28 17:31:07 PDT 
All reviewed patches have been landed.  Closing bug.