Bug 130915 - Radio buttons and checkboxes should share code
Summary: Radio buttons and checkboxes should share code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-28 16:14 PDT by Beth Dakin
Modified: 2014-03-31 11:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.60 KB, patch)
2014-03-28 16:21 PDT, Beth Dakin 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-03-28 16:14:31 PDT 
Radio buttons and checkboxes should share code, and this will easily allow radio buttons to pick up the work for incremental redraw that was added with https://bugs.webkit.org/show_bug.cgi?id=130736

<rdar://problem/16175198>
Comment 1 Beth Dakin 2014-03-28 16:21:59 PDT 
Created attachment 228089 [details]
Patch
Comment 2 Anders Carlsson 2014-03-29 07:44:39 PDT 
Comment on attachment 228089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228089&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:298
> +static const IntSize* radioSizes()

I think you should make this return a const std::array<IntSize, 3>&
Comment 3 Beth Dakin 2014-03-31 11:11:50 PDT 
Thanks, Sam! I will address Anders' suggestion in a follow-up patch. http://trac.webkit.org/changeset/166514