Bug 130909 - [iOS] Don't cancel composition on selection change
Summary: [iOS] Don't cancel composition on selection change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-28 12:24 PDT by Alexey Proskuryakov
Modified: 2014-03-28 15:06 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (1.57 KB, patch)
2014-03-28 12:26 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-28 12:24:31 PDT 
In bug 130727, I made it WebProcess responsibility to cancel composition on selection change. I thought that this didn't change iOS behavior, because we had this under PLATFORM(COCOA) in WebPageProxy.

But turns out that WebPageProxy::cancelComposition had a no-op implementation on iOS, unlike of the new WebProcess one.
Comment 1 Alexey Proskuryakov 2014-03-28 12:26:35 PDT 
Created attachment 228076 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-03-28 15:06:34 PDT 
Comment on attachment 228076 [details]
proposed fix

Clearing flags on attachment: 228076

Committed r166430: <http://trac.webkit.org/changeset/166430>
Comment 3 WebKit Commit Bot 2014-03-28 15:06:41 PDT 
All reviewed patches have been landed.  Closing bug.