Bug 130907 - AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if roleValue is ApplicationAlertRole || ApplicationStatusRole
Summary: AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-28 11:59 PDT by James Craig
Modified: 2014-04-01 09:37 PDT (History)
9 users (show)

See Also:


Attachments
patch (10.82 KB, patch)
2014-03-30 00:30 PDT, James Craig
no flags Details | Formatted Diff | Diff
patch (10.83 KB, patch)
2014-03-30 00:32 PDT, James Craig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2014-03-28 11:59:45 PDT
AX: AccessibilityObject::ariaLiveRegionAtomic() should default to true if roleValue() is ApplicationAlertRole || ApplicationStatusRole
Obviously an explicit @aria-atomic value of "false" should override the default.

http://www.w3.org/TR/wai-aria/complete#alert
http://www.w3.org/TR/wai-aria/complete#status
Comment 1 Radar WebKit Bug Importer 2014-03-28 12:00:17 PDT
<rdar://problem/16459599>
Comment 2 James Craig 2014-03-30 00:30:12 PDT
Created attachment 228122 [details]
patch
Comment 3 WebKit Commit Bot 2014-03-30 00:30:51 PDT
Attachment 228122 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3099:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 James Craig 2014-03-30 00:32:44 PDT
Created attachment 228123 [details]
patch
Comment 5 chris fleizach 2014-04-01 09:06:18 PDT
Comment on attachment 228123 [details]
patch

looking good!
Comment 6 WebKit Commit Bot 2014-04-01 09:37:11 PDT
Comment on attachment 228123 [details]
patch

Clearing flags on attachment: 228123

Committed r166594: <http://trac.webkit.org/changeset/166594>
Comment 7 WebKit Commit Bot 2014-04-01 09:37:14 PDT
All reviewed patches have been landed.  Closing bug.