WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130887
REGRESSION(
r166376
): This was a misguided optimization. (Requested by kling on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=130887
Summary
REGRESSION(r166376): This was a misguided optimization. (Requested by kling o...
WebKit Commit Bot
Reported
2014-03-27 22:21:45 PDT
http://trac.webkit.org/changeset/166376
broke the build: This was a misguided optimization. (Requested by kling on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r166376
(3.99 KB, patch)
2014-03-27 22:22 PDT
,
WebKit Commit Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2014-03-27 22:22:06 PDT
Created
attachment 228025
[details]
ROLLOUT of
r166376
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Commit Bot
Comment 2
2014-03-27 22:29:03 PDT
Comment on
attachment 228025
[details]
ROLLOUT of
r166376
Clearing flags on attachment: 228025 Committed
r166397
: <
http://trac.webkit.org/changeset/166397
>
WebKit Commit Bot
Comment 3
2014-03-27 22:29:06 PDT
All reviewed patches have been landed. Closing bug.
Mark Hahnenberg
Comment 4
2014-03-28 06:59:35 PDT
Why? I thought at least the change from structure -> newStructure in the second part of the patch made the code more readable.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug