Bug 130884 - [iOS][WK2] Adjust the tile coverage on the scrollview's edges
Summary: [iOS][WK2] Adjust the tile coverage on the scrollview's edges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-27 19:50 PDT by Benjamin Poulain
Modified: 2014-03-27 20:51 PDT (History)
0 users

See Also:


Attachments
Patch (2.77 KB, patch)
2014-03-27 19:53 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-03-27 19:50:50 PDT
[iOS][WK2] Adjust the tile coverage on the scrollview's edges
Comment 1 Benjamin Poulain 2014-03-27 19:53:12 PDT
Created attachment 228020 [details]
Patch
Comment 2 mitz 2014-03-27 20:06:25 PDT
Comment on attachment 228020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228020&action=review

> Source/WebCore/platform/ios/ScrollViewIOS.mm:168
> +    IntSize contentSize = contentsSize();
> +    if (futureRect.maxX() > contentSize.width())
> +        futureRect.setX(contentSize.width() - futureRect.width());
> +    if (futureRect.maxY() > contentSize.height())
> +        futureRect.setY(contentSize.height() - futureRect.height());
> +    if (futureRect.x() < 0)
> +        futureRect.setX(0);
> +    if (futureRect.y() < 0)
> +        futureRect.setY(0);
> +

Can’t this be written more concisely as intersecting futureRect with the rect { FloatPoint(), contentSize() }?
Comment 3 Benjamin Poulain 2014-03-27 20:51:10 PDT
Comment on attachment 228020 [details]
Patch

Clearing flags on attachment: 228020

Committed r166394: <http://trac.webkit.org/changeset/166394>
Comment 4 Benjamin Poulain 2014-03-27 20:51:11 PDT
All reviewed patches have been landed.  Closing bug.