RESOLVED FIXED 130884
[iOS][WK2] Adjust the tile coverage on the scrollview's edges 
https://bugs.webkit.org/show_bug.cgi?id=130884
Summary [iOS][WK2] Adjust the tile coverage on the scrollview's edges
Benjamin Poulain
Reported 2014-03-27 19:50:50 PDT
[iOS][WK2] Adjust the tile coverage on the scrollview's edges
Attachments
Patch (2.77 KB, patch)
2014-03-27 19:53 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-03-27 19:53:12 PDT
Created attachment 228020 [details] Patch
mitz
Comment 2 2014-03-27 20:06:25 PDT
Comment on attachment 228020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228020&action=review > Source/WebCore/platform/ios/ScrollViewIOS.mm:168 > + IntSize contentSize = contentsSize(); > + if (futureRect.maxX() > contentSize.width()) > + futureRect.setX(contentSize.width() - futureRect.width()); > + if (futureRect.maxY() > contentSize.height()) > + futureRect.setY(contentSize.height() - futureRect.height()); > + if (futureRect.x() < 0) > + futureRect.setX(0); > + if (futureRect.y() < 0) > + futureRect.setY(0); > + Can’t this be written more concisely as intersecting futureRect with the rect { FloatPoint(), contentSize() }?
Benjamin Poulain
Comment 3 2014-03-27 20:51:10 PDT
Comment on attachment 228020 [details] Patch Clearing flags on attachment: 228020 Committed r166394: <http://trac.webkit.org/changeset/166394>
Benjamin Poulain
Comment 4 2014-03-27 20:51:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.