Bug 130882 - Specify Shadow Pseudo Ids in Media Element Constructors
Summary: Specify Shadow Pseudo Ids in Media Element Constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 131044
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-27 18:07 PDT by Brent Fulgham
Modified: 2014-04-01 09:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.31 KB, patch)
2014-03-27 18:13 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-03-27 18:07:06 PDT 
Several media elements, e.g., the MediaControlTextTrackContainerElement, are not initialized with their Shadow DOM Pseudo Id (e.g., the "-webkit-media-text-track-container") value. When the pseudoId is not set, the Web Inspector can be confusing, because the element only displays as a "<div>", with nothing showing it's functional purpose in the media control hierarchy.

We should set the pseudo Id at construction time so that the object displays properly.
Comment 1 Brent Fulgham 2014-03-27 18:13:56 PDT 
Created attachment 228015 [details]
Patch
Comment 2 Brent Fulgham 2014-03-27 20:19:48 PDT 
It looks like inside WebCore itself, we call "shadowPseudoId()" to retrieve the value. However, the WebInspector and other pure JS clients call through the attribute access logic which only gets set up if a call to "setPseudo" is made at some point.

It would probably be wise to coalesce these two "separate but equal" concepts of shadow ID.
Comment 3 WebKit Commit Bot 2014-03-27 20:52:28 PDT 
Comment on attachment 228015 [details]
Patch

Clearing flags on attachment: 228015

Committed r166395: <http://trac.webkit.org/changeset/166395>
Comment 4 WebKit Commit Bot 2014-03-27 20:52:32 PDT 
All reviewed patches have been landed.  Closing bug.