Bug 130877 – Support spread operand in |new| expressions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Support spread operand in |new| expressions

[Oliver Hunt]

Created attachment 228010 [details]
Patch

[Michael Saboff]

Comment on attachment 228010 [details]
Patch

r=me
Any reason you didn't split this into the refactor and then the spread?

[Oliver Hunt]

(In reply to comment #2)
> (From update of attachment 228010 [details])
> r=me
> Any reason you didn't split this into the refactor and then the spread?

Because the only point of the refactor was so i could share code for op_construct_varargs i think the only thing that really counted as a refactor was emjtcompilevarargs in byecodegenerator

[Oliver Hunt]

Committed r166392: <http://trac.webkit.org/changeset/166392>

[Simon Fraser (smfr)]

This broke the CLOOP build.

[Filip Pizlo]

Comment on attachment 228010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228010&action=review

> LayoutTests/js/regress/script-tests/call-spread.js:34
> +
> +function testFunction(a, b)
> +{
> +    "use strict"
> +    result |= 0;
> +    return a * 1000 + b * 100 + arguments[2] * 10 + arguments.length ^ (result & 1024);
> +}
> +
> +var arrayArguments = [2, 3, 4]
> +var result = 0;
> +for (var i = 0; i < 1000000; i++)
> +    result += testFunction(...arrayArguments);
> +
> +for (var i = 0; i < 1000000; i++)
> +    result += testFunction(...[1, 2, result, 4]);
> +
> +function test2() {
> +    for (var i = 0; i < 1000000; i++)
> +        result += testFunction(...arguments);
> +}
> +
> +test2(1,2,3,4)
> +
> +
> +function test3() {
> +    aliasedArguments = arguments;
> +    for (var i = 0; i < 1000000; i++)
> +        result += testFunction(...aliasedArguments);
> +}
> +
> +test3(1,2,result,4)
> +
> +if (result != -856444619779264)
> +    throw "Result was " + result + " expected -856444619779264";

Is there a reason why this test needs to run for 30 seconds?

> LayoutTests/js/regress/script-tests/new-spread.js:34
> +
> +function testFunction(a, b)
> +{
> +    "use strict"
> +    result |= 0;
> +    result += a * 1000 + b * 100 + arguments[2] * 10 + arguments.length ^ (result & 1024);
> +}
> +
> +var arrayArguments = [2, 3, 4]
> +var result = 0;
> +for (var i = 0; i < 1000000; i++)
> +    new testFunction(...arrayArguments);
> +
> +for (var i = 0; i < 1000000; i++)
> +    new testFunction(...[1, 2, result, 4]);
> +
> +function test2() {
> +    for (var i = 0; i < 1000000; i++)
> +        new testFunction(...arguments);
> +}
> +
> +test2(1,2,3,4)
> +
> +
> +function test3() {
> +    aliasedArguments = arguments;
> +    for (var i = 0; i < 1000000; i++)
> +        new testFunction(...aliasedArguments);
> +}
> +
> +test3(1,2,result,4)
> +
> +if (result != -2371153088)
> +    throw "Result was " + result + " expected -2371153088";

Is there a reason why this test next to run for 40 seconds?