Bug 130874 - A TrailingObject's endpoint might get decremented twice
Summary: A TrailingObject's endpoint might get decremented twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-27 16:37 PDT by Myles C. Maxfield
Modified: 2014-03-28 10:33 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.02 KB, patch)
2014-03-27 16:40 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (4.02 KB, patch)
2014-03-27 16:49 PDT, Myles C. Maxfield
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-03-27 16:37:16 PDT
A TrailingObject's endpoint might get decremented twice
Comment 1 Myles C. Maxfield 2014-03-27 16:40:31 PDT
Created attachment 228006 [details]
Patch
Comment 2 Myles C. Maxfield 2014-03-27 16:41:31 PDT
Comment on attachment 228006 [details]
Patch

This is probably the worse ChangeLog that I have ever written.
Comment 3 Myles C. Maxfield 2014-03-27 16:49:42 PDT
Created attachment 228007 [details]
Patch
Comment 4 Tim Horton 2014-03-27 16:54:53 PDT
Comment on attachment 228007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review

> Source/WebCore/ChangeLog:9
> +        1. When we have both an ending position and it's accompanying starting

its :|
Comment 5 Myles C. Maxfield 2014-03-27 16:55:37 PDT
Comment on attachment 228007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review

> Source/WebCore/ChangeLog:8
> +        There are two places where we decrement a TrailingObject's ending position.

There are more than two, but these are the two that I am interested in.
Comment 6 Myles C. Maxfield 2014-03-27 17:07:28 PDT
<rdar://problem/16432098>
Comment 7 Darin Adler 2014-03-28 01:05:32 PDT
Comment on attachment 228007 [details]
Patch

Code change looks fine. Not sure what the point is of writing such a long change log. If this is really hard to understand, then I think we would need a comment instead of a change log entry. Next time you find you are writing a log this long, I suggest talking to another WebKit contributor in person. Together you can probably come up with a shorter explanation. I find that the process of talking through it out loud helps.
Comment 8 Myles C. Maxfield 2014-03-28 10:33:01 PDT
http://trac.webkit.org/changeset/166412