WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130874
A TrailingObject's endpoint might get decremented twice
https://bugs.webkit.org/show_bug.cgi?id=130874
Summary
A TrailingObject's endpoint might get decremented twice
Myles C. Maxfield
Reported
2014-03-27 16:37:16 PDT
A TrailingObject's endpoint might get decremented twice
Attachments
Patch
(3.02 KB, patch)
2014-03-27 16:40 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(4.02 KB, patch)
2014-03-27 16:49 PDT
,
Myles C. Maxfield
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2014-03-27 16:40:31 PDT
Created
attachment 228006
[details]
Patch
Myles C. Maxfield
Comment 2
2014-03-27 16:41:31 PDT
Comment on
attachment 228006
[details]
Patch This is probably the worse ChangeLog that I have ever written.
Myles C. Maxfield
Comment 3
2014-03-27 16:49:42 PDT
Created
attachment 228007
[details]
Patch
Tim Horton
Comment 4
2014-03-27 16:54:53 PDT
Comment on
attachment 228007
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=228007&action=review
> Source/WebCore/ChangeLog:9 > + 1. When we have both an ending position and it's accompanying starting
its :|
Myles C. Maxfield
Comment 5
2014-03-27 16:55:37 PDT
Comment on
attachment 228007
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=228007&action=review
> Source/WebCore/ChangeLog:8 > + There are two places where we decrement a TrailingObject's ending position.
There are more than two, but these are the two that I am interested in.
Myles C. Maxfield
Comment 6
2014-03-27 17:07:28 PDT
<
rdar://problem/16432098
>
Darin Adler
Comment 7
2014-03-28 01:05:32 PDT
Comment on
attachment 228007
[details]
Patch Code change looks fine. Not sure what the point is of writing such a long change log. If this is really hard to understand, then I think we would need a comment instead of a change log entry. Next time you find you are writing a log this long, I suggest talking to another WebKit contributor in person. Together you can probably come up with a shorter explanation. I find that the process of talking through it out loud helps.
Myles C. Maxfield
Comment 8
2014-03-28 10:33:01 PDT
http://trac.webkit.org/changeset/166412
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug